refactor: update ubuntu/authd paths to canonical/authd#1332
Merged
nooreldeenmansour merged 2 commits intomainfrom Apr 6, 2026
Merged
refactor: update ubuntu/authd paths to canonical/authd#1332nooreldeenmansour merged 2 commits intomainfrom
ubuntu/authd paths to canonical/authd#1332nooreldeenmansour merged 2 commits intomainfrom
Conversation
nooreldeenmansour
force-pushed
the
update-paths
branch
from
a78cb2c to
0741417
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors repository references from ubuntu/authd to canonical/authd across the OIDC brokers module and snap packaging metadata, while preserving DBus interface naming.
Changes:
- Update Go imports and module dependencies to
github.com/canonical/authd(notably the sharedlogpackage). - Adjust snapcraft builds to compile the brokers from the repo root (to accommodate a temporary Go module replace).
- Update README/codecov links and snap metadata URLs to the Canonical GitHub namespace.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| snap/variants/oidc/snapcraft.yaml | Build brokers from repo root; add temporary build workaround comments. |
| snap/variants/msentraid/snapcraft.yaml | Update metadata URLs; build brokers from repo root; update ldflags import path. |
| snap/variants/google/snapcraft.yaml | Update metadata URLs; build brokers from repo root; update ldflags import path. |
| authd-oidc-brokers/internal/testutils/provider.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/providers/msentraid/msentraid_test.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/providers/msentraid/msentraid.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/providers/msentraid/himmelblau/himmelblau_c.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/providers/msentraid/himmelblau/himmelblau.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/dbusservice/methods.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/daemon/daemon.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/consts/consts.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/broker/encrypt.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/broker/broker_test.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/internal/broker/broker.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/go.sum | Drop ubuntu/authd sums; bump go-systemd/v22 sums. |
| authd-oidc-brokers/go.mod | Replace module dependency from ubuntu/authd to canonical/authd and add temporary replace to ../. |
| authd-oidc-brokers/cmd/authd-oidc/main.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/cmd/authd-oidc/daemon/daemon.go | Switch log import to github.com/canonical/authd/log. |
| authd-oidc-brokers/cmd/authd-oidc/daemon/config.go | Switch log import to github.com/canonical/authd/log. |
| README.md | Update Codecov badge URLs to canonical/authd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 86.41% 80.08% -6.34%
==========================================
Files 99 20 -79
Lines 6690 984 -5706
Branches 111 0 -111
==========================================
- Hits 5781 788 -4993
+ Misses 853 196 -657
+ Partials 56 0 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nooreldeenmansour
force-pushed
the
update-paths
branch
from
0741417 to
01128d6
Compare
adombeck
reviewed
Mar 18, 2026
adombeck
reviewed
Mar 18, 2026
nooreldeenmansour
force-pushed
the
update-paths
branch
2 times, most recently
from
e3a7c5f to
446f564
Compare
adombeck
requested changes
Apr 6, 2026
The `export GOFLAGS="-ldflags=..."` in override-build was overwriting the `GOFLAGS: "-tags=release"` set in build-environment, causing the release tag to be silently dropped during compilation. This tag controls whether the build-time source directory is embedded as RPATH in the binary for msentraid broker Moved `-tags=release` directly to each variant's go build command line and passed `-ldflags` as a flag instead GOFLAGS export. This ensures the tag is always applied and makes all flags explicit and visible.
nooreldeenmansour
force-pushed
the
update-paths
branch
from
446f564 to
0513f0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all references of
ubuntu/authdtocanonical/authd, with exception to DBus paths, and Launchpad PPA urls.UDENG-9438